mirror/crumbs-original
1
0
Fork 1
mirror of https://github.com/bretzel-app/crumbs.git synced 2026-10-12 12:06:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: address PR review — a11y, checked detection, test fixes

Browse Source 
- Remove unused flushSync import
- Fix removeItem single-item branch: emit change and trigger reactivity
- Remove misleading role="button" + tabindex from drag handle
- Use anchored regex for checked detection instead of line.includes('[x]')
  in NoteCard and public share page (prevents false positive on item text)
- Fix NoteCard preview E2E test: scope assertion to specific card, use
  unique title to avoid collision
- Restore arrow key navigation E2E test

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Frederic Cabassut
2026-03-21 23:51:46 +01:00
committed by Fred Cabassut
co-authored by Claude Opus 4.6
parent 0124c5e7f6
commit 2267474cd5
4 changed files with 33 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/checklist.spec.ts
+28 -4
View File
@@ -136,6 +136,29 @@ test.describe('Checklist', () => {
await expect(page.getByTestId('checklist-done-section')).toContainText('Done task');
});
test('Scenario: Arrow keys navigate between checklist items', async ({ authenticatedPage: page }) => {
// Given a checklist with three items
await page.getByTestId('new-note-btn').click();
await page.getByTestId('checklist-toggle').click();
await page.getByTestId('checklist-input').first().fill('First');
await page.getByTestId('checklist-input').first().press('Enter');
await page.getByTestId('checklist-input').nth(1).fill('Second');
await page.getByTestId('checklist-input').nth(1).press('Enter');
await page.getByTestId('checklist-input').nth(2).fill('Third');
// When the user presses ArrowUp from the third item
await page.getByTestId('checklist-input').nth(2).press('ArrowUp');
// Then focus moves to the second item
await expect(page.getByTestId('checklist-input').nth(1)).toBeFocused();
// When the user presses ArrowDown
await page.getByTestId('checklist-input').nth(1).press('ArrowDown');
// Then focus moves back to the third item
await expect(page.getByTestId('checklist-input').nth(2)).toBeFocused();
});
test('Scenario: Tab indents an item and Shift+Tab outdents it', async ({ authenticatedPage: page }) => {
// Given a checklist with two top-level items
await page.getByTestId('new-note-btn').click();
@@ -249,13 +272,14 @@ test.describe('Checklist', () => {
test('Scenario: NoteCard preview shows indentation for nested items', async ({ authenticatedPage: page }) => {
// Given a checklist note with nested items
await createChecklistNote(page, 'Preview Indent', ['Parent', 'Child']);
await noteCard(page, 'Preview Indent').click();
await createChecklistNote(page, 'Indent Preview Note', ['Parent', 'Child']);
await noteCard(page, 'Indent Preview Note').click();
await page.getByTestId('checklist-input').nth(1).press('Tab');
await page.getByTestId('close-editor-btn').click();
// Then the NoteCard preview shows the child indented
await expect(page.getByTestId('card-checklist-child')).toHaveCount(1);
// Then the NoteCard preview shows the child indented (scoped to this card)
const card = noteCard(page, 'Indent Preview Note');
await expect(card.getByTestId('card-checklist-child')).toHaveCount(1);
});
test('Scenario: Disabling checklist mode restores the rich text editor', async ({ authenticatedPage: page }) => {