From a54c117c766511237c637ead88b40ebccbf69922 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Wed, 11 Mar 2026 19:26:43 +0000
Subject: [PATCH] fix: address code review feedback on NoteHistory component

Co-authored-by: fredicious <1580688+fredicious@users.noreply.github.com>
---
 src/lib/components/NoteHistory.svelte | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/lib/components/NoteHistory.svelte b/src/lib/components/NoteHistory.svelte
index 65550ab..1b84c60 100644
--- a/src/lib/components/NoteHistory.svelte
+++ b/src/lib/components/NoteHistory.svelte
@@ -21,6 +21,8 @@
 	let showConfirm = $state(false);
 
 	$effect(() => {
+		// Track noteId explicitly so this only re-runs when the note changes
+		noteId;
 		void loadVersions();
 	});
 
@@ -122,9 +124,9 @@
 			</button>
 		</div>
 
-		<div class="flex min-h-0 flex-1">
+		<div class="flex min-h-0 max-h-[60vh] flex-1">
 			<!-- Version list -->
-			<div class="w-56 flex-none border-r border-[var(--border-subtle)] overflow-y-auto max-h-[60vh]">
+			<div class="w-56 flex-none border-r border-[var(--border-subtle)] overflow-y-auto">
 				{#if isLoading}
 					<div class="flex items-center justify-center py-8 text-sm text-[var(--text-muted)]">
 						Loading…
@@ -166,7 +168,7 @@
 						Loading…
 					</div>
 				{:else if selectedVersion}
-					<div class="flex flex-1 flex-col overflow-y-auto max-h-[60vh]">
+					<div class="flex flex-1 flex-col overflow-y-auto">
 						<div class="flex-1 overflow-y-auto px-4 py-3">
 							{#if selectedVersion.title}
 								<h3 class="mb-2 text-base font-semibold text-[var(--text)]">{selectedVersion.title}</h3>