From 02a6a3e6c6ab5262ccd899d69fbedf013b56929e Mon Sep 17 00:00:00 2001
From: Frederic Cabassut <cabassut.frederic@gmail.com>
Date: Tue, 10 Mar 2026 15:10:31 +0100
Subject: [PATCH] fix: redirect /settings to /settings/preferences

Move Profile page to /settings/profile and add a 302 redirect from
/settings to /settings/preferences so the first settings tab is
Preferences, not Profile.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 src/routes/(app)/settings/+layout.svelte             | 4 ++--
 src/routes/(app)/settings/+page.server.ts            | 5 +++++
 src/routes/(app)/settings/{ => profile}/+page.svelte | 0
 tests/e2e/settings.spec.ts                           | 6 +++---
 4 files changed, 10 insertions(+), 5 deletions(-)
 create mode 100644 src/routes/(app)/settings/+page.server.ts
 rename src/routes/(app)/settings/{ => profile}/+page.svelte (100%)

diff --git a/src/routes/(app)/settings/+layout.svelte b/src/routes/(app)/settings/+layout.svelte
index cd933fa..9189284 100644
--- a/src/routes/(app)/settings/+layout.svelte
+++ b/src/routes/(app)/settings/+layout.svelte
@@ -29,8 +29,8 @@
 				</li>
 				<li>
 					<a
-						href="/settings"
-						class="flex items-center gap-2 rounded-sm px-3 py-2 text-sm whitespace-nowrap transition-colors {pathname === '/settings' ? 'bg-[var(--primary)]/15 text-[var(--primary)] font-medium' : 'text-[var(--text)] hover:bg-[var(--bg-base)]'}"
+						href="/settings/profile"
+						class="flex items-center gap-2 rounded-sm px-3 py-2 text-sm whitespace-nowrap transition-colors {pathname === '/settings/profile' ? 'bg-[var(--primary)]/15 text-[var(--primary)] font-medium' : 'text-[var(--text)] hover:bg-[var(--bg-base)]'}"
 					>
 						<User size={16} />
 						Profile
diff --git a/src/routes/(app)/settings/+page.server.ts b/src/routes/(app)/settings/+page.server.ts
new file mode 100644
index 0000000..096ad63
--- /dev/null
+++ b/src/routes/(app)/settings/+page.server.ts
@@ -0,0 +1,5 @@
+import { redirect } from '@sveltejs/kit';
+
+export function load() {
+	redirect(302, '/settings/preferences');
+}
diff --git a/src/routes/(app)/settings/+page.svelte b/src/routes/(app)/settings/profile/+page.svelte
similarity index 100%
rename from src/routes/(app)/settings/+page.svelte
rename to src/routes/(app)/settings/profile/+page.svelte
diff --git a/tests/e2e/settings.spec.ts b/tests/e2e/settings.spec.ts
index 103c094..addeeec 100644
--- a/tests/e2e/settings.spec.ts
+++ b/tests/e2e/settings.spec.ts
@@ -114,8 +114,8 @@ test.describe('Settings — API Key Management', () => {
 		// When the user clicks the Settings link in the sidebar
 		await page.getByTestId('settings-link').click();
 
-		// Then the settings page is shown
-		await expect(page).toHaveURL('/settings');
+		// Then the settings page redirects to preferences
+		await expect(page).toHaveURL('/settings/preferences');
 		await expect(page.getByRole('heading', { name: 'Settings' })).toBeVisible();
 	});
 
@@ -134,6 +134,6 @@ test.describe('Settings — API Key Management', () => {
 
 		// When the user clicks back to Profile
 		await page.getByRole('link', { name: 'Profile' }).click();
-		await expect(page).toHaveURL('/settings');
+		await expect(page).toHaveURL('/settings/profile');
 	});
 });